callstack/react-native-paper

TextInput component's right prop should accept any React.ReactNode content

Open

#2,866 opened on Aug 20, 2021

View on GitHub
 (10 comments) (1 reaction) (0 assignees)TypeScript (2,005 forks)batch import
HacktoberfestStaleTextInputenhancement

Repository metrics

Stars
 (11,550 stars)
PR merge metrics
 (Avg merge 8d 12h) (10 merged PRs in 30d)

Description

Is your feature request related to a problem? Please describe. I want to be able to show an ActivityIndicator as the right prop for the TextInput to show loading states.

Describe the solution you'd like The TextInput component's right prop should accept any React.ReactNode content and render it on the right side of the input.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context This is what I would expect the final result to look like

react-native: 0.65.1 react-native-paper: 4.9.2 react-native-vector-icons: 8.1.0

repro: snack example

Contributor guide

Research direction
Investigate how the TextInput component currently handles the 'right' prop, check TypeScript type definitions, and modify the component to accept any ReactNode. Look for existing patterns in the codebase for similar props.
Tech stack
typescriptreact native
Domain
mobile
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactReact NativeTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70