canonical/mir

CompositorPerformance test uses its own idiosyncratic server runner

Open

#1,653 opened on Aug 4, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (137 forks)auto 404
Good first issue

Repository metrics

Stars
 (775 stars)
PR merge metrics
 (PR metrics pending)

Description

performance_tests/test_compositor.cpp uses its own, weird server runner involving parsing the output of Mir's stdout. Mostly this is harmless, albeit weird, but it means that it errors out when the MIR_SERVER_LOGGING is set in the environment.

With a few small and reasonably sensible changes to the CompositorReport infrastructure this could just be a normal AsyncTestRunner test.

Contributor guide

Research direction
Examine the existing CompositorReport infrastructure and the AsyncTestRunner to understand how to convert the test's custom server runner to use the standard testing framework.
Tech stack
cpp
Domain
backendtesting
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++testing infrastructure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50