canonical/mir

WindowManager::add_display()/remove_display()

Open

#2,148 opened on Aug 20, 2021

View on GitHub
 (4 comments) (0 reactions) (1 assignee)C++ (137 forks)auto 404
Good first issue

Repository metrics

Stars
 (775 stars)
PR merge metrics
 (PR metrics pending)

Description

In one of the implementations of this interface SystemCompositorWindowManager we have:

    void add_display(mir::geometry::Rectangle const& area) override
    __attribute__((deprecated("Mir doesn't reliably call this: it is ignored. Use add_display_for_testing() instead")));

And, in this implementation, the outputs are tracked by the ActiveOutputsListener interface.

But the other implementation SystemCompositorWindowManager uses this function to track the outputs.

There's clearly something wrong with the diagnostic, one of the implementations, or several of these.

Contributor guide

Research direction
Investigate the two implementations of WindowManager interface. Determine which implementation's use of add display is correct and update the deprecated annotation accordingly.
Tech stack
cpp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70