cardano-php/bech32

Minor Suggestions

Open

#3 opened on Jan 2, 2025

View on GitHub
 (0 comments) (0 reactions) (0 assignees)PHP (0 forks)auto 404
good first issue

Repository metrics

Stars
 (2 stars)
PR merge metrics
 (PR metrics pending)

Description

Minor:

  • Add Tests for Empty Data Arrays:

    • Ensure that encoding with empty data arrays produces the expected Bech32 string format.

  • Enhance HRP Validation:

    • Implement and test checks to ensure that the HRP contains only valid Bech32 characters.

Originally posted by @latheesan-k in https://github.com/cardano-php/bech32/pull/1#discussion_r1901198140

Contributor guide

Research direction
Examine the existing Bech32 encoder/decoder code and test files. Add unit tests for empty data arrays and implement HRP character validation using a regex check.
Tech stack
php
Domain
backendblockchain
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PHPGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80