cardano-php/bech32

Minor: The `encode` method does not handle empty data arrays explicitly

Open

#4 opened on Jan 2, 2025

View on GitHub
 (0 comments) (0 reactions) (0 assignees)PHP (0 forks)auto 404
good first issue

Repository metrics

Stars
 (2 stars)
PR merge metrics
 (PR metrics pending)

Description

Minor: The encode method does not handle empty data arrays explicitly. While the current tests do not cover this, it should be ensured that encoding with an empty data array results in a valid Bech32 string with only the HRP and separator.

Originally posted by @latheesan-k in https://github.com/cardano-php/bech32/pull/1#discussion_r1901181949

Contributor guide

Research direction
Inspect the encode function and add handling for empty data array input.
Tech stack
php
Domain
blockchain
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PHPGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75