codex-team/editor.js

TypeError: Cannot read properties of undefined (reading 'isInternal')

Open

#2,563 opened on Dec 16, 2023

View on GitHub
 (3 comments) (0 reactions) (0 assignees)TypeScript (1,985 forks)batch import
good first issueissue for docs

Repository metrics

Stars
 (26,602 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hello! I'm trying to create a block tune for one of my apps, here is the code:

class MyBlockTune {
  constructor({ api }) {
    this.api = api;
  }

  isTune() {
    return true
  }

  render() {
    return [
      {
        icon: '<svg>...</svg>',
        label: 'Tune label',
        onActivate: () => { }
      }
    ]
  }
}

After activating it with:

{
  tools: {
    myBlockTune: MyBlockTune,
  },
  tunes: ['myBlockTune'],
}

Editor instance crashes with a following exception thrown:

Which is this line:

After investigating this line a bit with debugger, i can see that this.tunes.myBlockTune is not an instance of anything but is undefined instead.

Editor.js version: 2.28.2

Contributor guide

Research direction
Investigate the initialization of tunes in the editor.js core to understand why `this.tunes.myBlockTune` is undefined. Check the `isInternal` method location and trace the property assignment during block tune registration.
Tech stack
javascripttypescript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptnpmeditor.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65