danger/danger

Danger local doesn't work for private repos

Open

#231 opened on Jun 1, 2016

View on GitHub
 (9 comments) (0 reactions) (0 assignees)Ruby (491 forks)batch import
EnhancementHelp Wanted

Repository metrics

Stars
 (5,297 stars)
PR merge metrics
 (Avg merge 60d 8h) (5 merged PRs in 30d)

Description

$ bundle exec danger local
Running your Dangerfile against this PR - https://github.com/starsirius/superposition/pull/37
Turning on --verbose

/Users/starsirius/.rvm/gems/ruby-2.2.2/gems/octokit-4.3.0/lib/octokit/response/raise_error.rb:16:in `on_complete': GET https://api.github.com/repos/starsirius/superposition/pulls/37: 404 - Not Found // See: https://developer.github.com/v3 (Octokit::NotFound)
    from /Users/starsirius/.rvm/gems/ruby-2.2.2/gems/faraday-0.9.1/lib/faraday/response.rb:9:in `block in call'
    from /Users/starsirius/.rvm/gems/ruby-2.2.2/gems/faraday-0.9.1/lib/faraday/response.rb:57:in `on_complete'
    from /Users/starsirius/.rvm/gems/ruby-2.2.2/gems/faraday-0.9.1/lib/faraday/response.rb:8:in `call'
    from /Users/starsirius/.rvm/gems/ruby-2.2.2/gems/octokit-4.3.0/lib/octokit/middleware/follow_redirects.rb:73:in `perform_with_redirection'
    from /Users/starsirius/.rvm/gems/ruby-2.2.2/gems/octokit-4.3.0/lib/octokit/middleware/follow_redirects.rb:61:in `call'
    from /Users/starsirius/.rvm/gems/ruby-2.2.2/gems/faraday-0.9.1/lib/faraday/rack_builder.rb:139:in `build_response'
    from /Users/starsirius/.rvm/gems/ruby-2.2.2/gems/faraday-0.9.1/lib/faraday/connection.rb:377:in `run_request'
    from /Users/starsirius/.rvm/gems/ruby-2.2.2/gems/faraday-0.9.1/lib/faraday/connection.rb:140:in `get'
    from /Users/starsirius/.rvm/gems/ruby-2.2.2/gems/sawyer-0.7.0/lib/sawyer/agent.rb:94:in `call'
    from /Users/starsirius/.rvm/gems/ruby-2.2.2/gems/octokit-4.3.0/lib/octokit/connection.rb:154:in `request'
    from /Users/starsirius/.rvm/gems/ruby-2.2.2/gems/octokit-4.3.0/lib/octokit/connection.rb:19:in `get'
    from /Users/starsirius/.rvm/gems/ruby-2.2.2/gems/octokit-4.3.0/lib/octokit/client/pull_requests.rb:31:in `pull_request'
    from /Users/starsirius/.rvm/gems/ruby-2.2.2/gems/danger-0.7.4/lib/danger/request_sources/github.rb:35:in `fetch_details'
    from /Users/starsirius/.rvm/gems/ruby-2.2.2/gems/danger-0.7.4/lib/danger/commands/local.rb:52:in `run'
    from /Users/starsirius/.rvm/gems/ruby-2.2.2/gems/claide-1.0.0/lib/claide/command.rb:334:in `run'
    from /Users/starsirius/.rvm/gems/ruby-2.2.2/gems/danger-0.7.4/bin/danger:5:in `<top (required)>'
    from /Users/starsirius/.rvm/gems/ruby-2.2.2/bin/danger:23:in `load'
    from /Users/starsirius/.rvm/gems/ruby-2.2.2/bin/danger:23:in `<main>'

Contributor guide

Research direction
Investigate the authentication flow in the local command. Look at how the GitHub token is obtained and used for private repo access. Check if there is a missing environment variable or configuration.
Tech stack
ruby
Domain
ci cd
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
RubyGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70