derhuerst/generate-db-shop-urls

matching stations without Betreiber-Nr/Bahnhofsnummer doesn't work

Open

#49 opened on Dec 4, 2022

View on GitHub
 (10 comments) (0 reactions) (0 assignees)HTML (2 forks)github user discovery
bughelp wantedupstream

Repository metrics

Stars
 (20 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

As mentioned here: https://github.com/juliuste/bahn.guru/issues/32#issuecomment-1336184685

Most links seem to work, though upon further testing Links with MEs seem to be broken e.g.: this one and this one.

Not sure what kind of v5.db.transport.rest info to provide, but it seems to affect any connection with at least one "ME", "RE" or "RB".

Contributor guide

Research direction
Investigate the station matching logic in the codebase, focusing on how stations are identified by 'Betreiber Nr' or 'Bahnhofsnummer'. The bug occurs when a leg has a line with product 'ME', 'RE', or 'RB' where the station lacks such an identifier. Check the function that matches stations from the journey to the database, and see how it handles cases where 'Betreiber Nr' is missing.
Tech stack
javascriptnodejs
Domain
backendapi
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptGitNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75