derhuerst/match-gtfs-rt-to-gtfs

allow customising the DB schema

Open

#8 opened on Feb 16, 2024

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (1 fork)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (5 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

This use case has been brought up in https://github.com/derhuerst/berlin-gtfs-rt-server/issues/9.

berlin-gtfs-rt-server uses hafas-gtfs-rt-feed underneath, which in turn uses gtfs-via-postgres & match-gtfs-rt-to-gtfs. The former already supports using a schema other than public, but match-gtfs-rt-to-gtfs doesn't support it yet.

Two places would have to be adapted:

  • The build-index command needs a new option (e.g. --db-schema).
  • The actual matching logic (index.js) needs a new option (e.g. dbSchema).

The name of the schema should be added to the DB queries in a secure manner, e.g. by using pg-format.

Contributor guide

Research direction
Add a new option for DB schema to the build index command and the matching logic, using pg format for safe SQL injection prevention.
Tech stack
javascriptnodejspostgresql
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75