derhuerst/node-sockopt

handle non-integer flags

Open

#1 opened on Feb 25, 2020

View on GitHub
 (1 comment) (1 reaction) (0 assignees)JavaScript (3 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (9 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

From https://github.com/derhuerst/node-sockopt/blob/19410b3a048efa3bbb3f955e677e438bbdc6104d/index.js#L21-L25:

Currently _setsockopt (& _getsockopt) only handles integers. todo: fails with e.g. SO_RCVTIMEO/SO_SNDTIMEO

if (!Number.isInteger(flagValue)) {
	throw new Error('flagValue must be an integer')
}

The native code would have to be adapted to create the appropriate structs for selected flags.

Contributor guide

Research direction
Examine the native addon code at lib/binding.c or similar, understand how setsockopt is currently called with integers, and adapt it to handle non integer flags like SO RCVTIMEO by constructing the appropriate struct (e.g., struct timeval) and passing it to setsockopt.
Tech stack
javascriptccpp
Domain
backendapi
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C/C++Node.js native addon developmentSocket programming
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30