derhuerst/parse-human-relative-time

Unable to define weekStartsOn parameter

Open

#4 opened on Feb 24, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (4 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (36 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Some countries might start the week on another day, which can be configured in date-fns weekStartsOn parameter.

Unfortunately, this cannot be passed over here due to fixed lexing: https://github.com/derhuerst/parse-human-relative-time/blob/1fd21930e4568588233f33746984a152ba9bc6ab/date-fns.js#L18

Can we figure a way, a solution, how to support such a parameter?

Contributor guide

Research direction
Examine the lexing function in date fns.js and modify it to accept an optional weekStartsOn parameter, then propagate it to the date fns functions.
Tech stack
javascript
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75