derhuerst/read-audio-tags

readTags function does not return on cb if (!tags) check is true causing callback to be called twice

Open

#10 opened on Feb 10, 2023

View on GitHub
 (3 comments) (0 reactions) (1 assignee)JavaScript (2 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (6 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

index.js line 28 has if (!tags) cb(new Error('ffprobe returned invalid data')) It should be if (!tags) return cb(new Error('ffprobe returned invalid data'))

Otherwise an invalid set of tags will cause cb to be called twice (by the line below this check)

Contributor guide

Research direction
Add a return statement before calling cb with error to prevent double callback.
Tech stack
javascript
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90