diasurgical/devilutionX

Cleanup manual value clamping

Open

#1,666 opened on Apr 24, 2021

View on GitHub
 (2 comments) (1 reaction) (0 assignees)C++ (743 forks)batch import
good first issuehelp wanted

Repository metrics

Stars
 (7,255 stars)
PR merge metrics
 (Avg merge 2d 12h) (15 merged PRs in 30d)

Description

The code is littered with conditions that check that values do not go over or under the min/max range.

This is relatively easy but tedious to clean up, but doing so greatly helps the readability of the code.

An example of such cleanups in inv.cpp and a couple of other files: https://github.com/diasurgical/devilutionX/pull/1665

Contributor guide

Research direction
Review PR #1665 for examples of replacing manual value clamping with helper functions or std::clamp, then apply similar pattern to other files with manual clamping, ensuring no functionality changes.
Tech stack
cpp
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75