diasurgical/devilutionX

Desync in spellcasting and attacks

Open

#2,681 opened on Aug 23, 2021

View on GitHub
 (4 comments) (0 reactions) (0 assignees)C++ (743 forks)batch import
help wanted

Repository metrics

Stars
 (7,255 stars)
PR merge metrics
 (Avg merge 2d 12h) (15 merged PRs in 30d)

Description

Caused by ab8afa7cd7e83b7df295cac7956cd6358f068728

allspellsbroke

To reproduce: just get 2 players, 1 casts/attacks once, 2 sees more than one cast/attack Only reproductible on lowest game speed, cast/attack multiple times, it doesn't always happen

Contributor guide

Research direction
Identify the commit ab8afa7cd7e83b7df295cac7956cd6358f068728 and understand the netcode changes. Focus on the synchronization logic for spellcasting and attacks. Reproduce with two players at lowest game speed and trace the network packets to find where the desync originates.
Tech stack
cpp
Domain
game dev
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Needs investigation
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40