diasurgical/devilutionX

Converting hellfire save to diablo while having a hellfire spell selected

Open

#3,466 opened on Nov 10, 2021

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C++ (743 forks)batch import
buggood first issue

Repository metrics

Stars
 (7,255 stars)
PR merge metrics
 (Avg merge 2d 12h) (15 merged PRs in 30d)

Description

If you convert a hellfire spell to diablo while having a hellfire spell selected, it will still be selected in devilutionx but without icon and you can still cast it, which will probably crash. If you try to load such a save in vanilla, it will crash. Spell selection should be cleared while converting saves if it's a hellfire spell.

Contributor guide

Research direction
Identify the save conversion code path and ensure that when converting from Hellfire to Diablo, the current spell selection is cleared if it is a Hellfire spell.
Tech stack
cpp
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60