dry-rb/dry-validation

Support for "validate" helper within rule blocks

Open

#679 opened on Dec 16, 2020

View on GitHub
 (6 comments) (3 reactions) (0 assignees)Ruby (193 forks)github user discovery
featurehelp wanted

Repository metrics

Stars
 (1,421 stars)
PR merge metrics
 (PR metrics pending)

Description

Support for executing predicates using validate method within rule blocks will make it much easier to apply various checks with extra conditions:

params do
  optional(:per_page).filled(:integer)
end

rule(:per_page) do
  if key?
    key.failure("must be within 0..20 range") unless validate(gt?: 0, lteq?: 20)
  end
end

See the original conversation: https://github.com/dry-rb/dry-validation/issues/678

Contributor guide

Research direction
Study the rule block implementation in dry validation (e.g., Rule class and its evaluation context). Understand how predicates are currently executed and how to add a new `validate` helper that accepts predicate names with arguments. Check existing methods like `key?.failure` and the `validate` method in the validation context. Look at test files for rule blocks to understand the expected behavior.
Tech stack
ruby
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rubydry validation
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70