eWaterCycle/ewatercycle

coords_to_indices requires iterable

Open

#280 opened on Dec 6, 2021

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (6 forks)auto 404
enhancementgood first issue

Repository metrics

Stars
 (39 stars)
PR merge metrics
 (PR metrics pending)

Description

Based on student feedback:

Can we make it possible to pass non-iterables and iterables to the function coords_to_indices?

https://github.com/eWaterCycle/ewatercycle/blob/71bcc306b2ad2dfa224e793a3a9c30595174bbc5/src/ewatercycle/models/wflow.py#L182-L184

Contributor guide

Research direction
Modify the function coords to indices to accept both single values and iterables using a check (e.g., isinstance) and handle accordingly, then update the docstring and tests.
Tech stack
python
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90