eclipse-theia/theia

improve CORS handling by mini-browser

Open

#3,589 opened on Nov 22, 2018

View on GitHub
 (4 comments) (0 reactions) (0 assignees)TypeScript (2,478 forks)batch import
enhancementhelp wantedmini-browser

Repository metrics

Stars
 (18,676 stars)
PR merge metrics
 (Avg merge 15d 4h) (75 merged PRs in 30d)

Description

There are 2 cases to consider:

  • opening a URL with http from Theia deployed under https, in this case we should notify a user about CORS issues. Right now they are only logged in the dev tool console and the mini browser is spining forever.
  • opening a URL with https scheme, in this case some pages cannot be opened in iframe (see images below). The mini-browser should detect it and propose a user to open such page in a new browser tab.

Contributor guide

Research direction
Examine the mini browser implementation in Theia to understand how CORS errors and iframe restrictions are currently handled. Look for existing error handling in the mini browser widget and propose improvements to detect and surface CORS issues to the user.
Tech stack
typescript
Domain
frontendweb dev
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScriptWeb basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50