eclipse-theia/theia

Get rid of TerminalWidgetImpl

Open

#5,660 opened on Jul 8, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (2,478 forks)batch import
help wantedqualityterminal

Repository metrics

Stars
 (18,676 stars)
PR merge metrics
 (Avg merge 15d 4h) (75 merged PRs in 30d)

Description

It should be just TerminalWidget. If we want to abstract over different terminals, we should introduce Terminal interfaces and hide xterm behind it for TerminalWidget. We don't need another implementation of TerminalWidget itself.

Contributor guide

Research direction
Examine the current TerminalWidgetImpl and TerminalWidget classes, then refactor them into a single TerminalWidget class. Consider introducing a Terminal interface to abstract away xterm details.
Tech stack
typescript
Domain
desktop
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
TypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65