eclipse-theia/theia

[editor] search (ctrl+f) should be persistent across multiple editors

Open

#6,527 opened on Nov 11, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (2,478 forks)batch import
editorhelp wantedui/ux

Repository metrics

Stars
 (18,676 stars)
PR merge metrics
 (Avg merge 15d 4h) (75 merged PRs in 30d)

Description

Description

Currently, when multiple editors are opened and a user attempts to search in the editor (ctrl+f), the search is only persistent for the single editor. If an opened editor is switched, the search disappears. As an end user, I'd expect that the search box remains.

image

Comparing to VS Code, they keep the search box persistent across all opened editors. Is this an area we want to align?

Contributor guide

Research direction
Investigate how the search widget is created and destroyed when switching editors. Look at the editor context event handling and widget lifecycle to determine where to persist the search state.
Tech stack
typescript
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60