eclipse-theia/theia

Support workspaceSuffix argument in the ResourceLabelFormatter plugin API

Open

#8,321 opened on Aug 6, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (2,478 forks)batch import
help wantedplug-in systemvscode

Repository metrics

Stars
 (18,676 stars)
PR merge metrics
 (Avg merge 15d 4h) (75 merged PRs in 30d)

Description

Since the ResourceLabelFormatter plugin API was introduced by https://github.com/eclipse-theia/theia/pull/8187, it doesn't support workspaceSuffix argument.

Feature Description:

Proposal: Handle this argument in the getName() function of the WorkspaceUriLabelProviderContribution in the vscode way: https://github.com/microsoft/vscode/blob/1.47.3/src/vs/workbench/services/label/common/labelService.ts#L292-L296

Contributor guide

Research direction
Examine the existing getName() function in WorkspaceUriLabelProviderContribution and integrate the workspaceSuffix argument as done in vscode's labelService.ts.
Tech stack
typescript
Domain
backendapi
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70