eclipse-theia/theia

OnDidChangeBreakpoints() doesnt work the same way in theia as in vscode

Open

#8,851 opened on Dec 10, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (2,478 forks)batch import
debughelp wantedvscode

Repository metrics

Stars
 (18,676 stars)
PR merge metrics
 (Avg merge 15d 4h) (75 merged PRs in 30d)

Description

Notification about added, removed, or changed breakpoints received via onDidChangeBreakpoints() doesn't work the same way in theia as in vs code. Only added and removed breakpoints objects were returned via event when the condition of the breakpoint (for conditional breakpoint)in the debug editor was changed .

Steps to Reproduce:

1 Try using onDidChangeBreakpoints() from vscode extension.

vscode.debug.onDidChangeBreakpoints( event => { console.log(event); }) 2. Open the file in editor. 3. Right Click on Breakpoint. 4.Select Edit Breakpoint and try adding an expression. 5 Event is triggered but doesn't return changed Breakpoints with the updated condition like vscode. Instead only added and removed breakpoints are returned.

This functionality was required for validating the expression of the conditional breakpoint from vscode extension even when debug event is not started.

  • Theia Version: 1.7

Contributor guide

Research direction
Examine the implementation of onDidChangeBreakpoints in Theia's debug extension to understand why changed breakpoints are not returned. Compare with VS Code's implementation.
Tech stack
typescript
Domain
developer experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60