egoist/nwjs

32/64bits specified?

Open

#13 opened on Apr 28, 2016

View on GitHub
 (2 comments) (6 reactions) (0 assignees)JavaScript (19 forks)user submission
enhancementhelp wanted

Repository metrics

Stars
 (76 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

const fileName = version == realVersion ? `nwjs-v${realVersion}-${os.platform}-${os.arch}`

Currently it totally depends on os.arch, so does https://github.com/nwjs/npm-installer/issues/28. Unfortuately I need this feature :/ Our app is to be distributed in 32bits, so I need a 32bit version as well as 64 in my machine.

Contributor guide

Research direction
Implement an option to specify architecture (32 or 64 bit) in the installer, overriding the default os.arch detection.
Tech stack
javascriptnodejs
Domain
clitooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
npmNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60