elastic/elasticsearch

Fail sorting when the field is under a nested object but no `nested_path` is specified

Open

#21,704 opened on Nov 21, 2016

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Java (25,882 forks)batch import
:Search Relevance/Search>enhancementTeam:Search Relevancehelp wanted

Repository metrics

Stars
 (76,700 stars)
PR merge metrics
 (Avg merge 2d) (1,000 merged PRs in 30d)

Description

Follow-up to #21685. Maybe we should fail queries when a sort field is under a nested object and this nested object does not copy data to the parent/root (include_in_parent) since that would always be a mistake?

Contributor guide

Research direction
Examine the Elasticsearch sorting code for nested fields. Look at how `nested path` is used and whether validation is missing. Check the linked issue #21685 for context. Consider adding a validation error when a sort field is nested but `nested path` is not specified and the nested object does not use `include in parent`.
Tech stack
java
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ElasticsearchJava
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60