elastic/elasticsearch

Reindex requests do not implement x-content testing

Open

#43,456 opened on Jun 20, 2019

View on GitHub
 (5 comments) (0 reactions) (1 assignee)Java (25,882 forks)batch import
:Distributed/Reindex>tech-debt>testTeam:Distributedgood first issuev9.5.0v9.6.0

Repository metrics

Stars
 (76,700 stars)
PR merge metrics
 (Avg merge 2d) (1,000 merged PRs in 30d)

Description

Currently the three primary reindex plugin requests do not implement our standard AbstractXContentTestCase testing infrastructure. This infrastructure would have detected issues like #43406.

The requests in need are:

  • UpdateByQueryRequest
  • ReindexRequest
  • DeleteByQueryRequest

Contributor guide

Research direction
Examine the existing AbstractXContentTestCase implementation for ReindexRequest and replicate the pattern for UpdateByQueryRequest and DeleteByQueryRequest. Ensure proper serialization/deserialization and content verification.
Tech stack
java
Domain
backend
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70