elastic/kibana

Remove `export *` pattern from Data plugin

Open

#99,515 opened on May 6, 2021

View on GitHub
 (6 comments) (0 reactions) (0 assignees)TypeScript (8,021 forks)batch import
Feature:SearchTeam:DataDiscoverygood first issueimpact:mediumloe:smalltechnical debt

Repository metrics

Stars
 (19,065 stars)
PR merge metrics
 (Avg merge 1d 16h) (999 merged PRs in 30d)

Description

export * makes it easy for a developer to accidentally expose functionality on a plugin's public API, and so should be avoided in favor of explicit exports.

Looks like data/common/index.ts has quite a few: https://github.com/elastic/kibana/blob/master/src/plugins/data/common/index.ts#L9

Contributor guide

Research direction
Identify all `export *` statements in `src/plugins/data/common/index.ts` and replace them with explicit named exports. Ensure no imported functionality is accidentally removed by verifying that each exported symbol is actually used elsewhere. Run the existing tests to confirm no regressions.
Tech stack
typescript
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85