emissary-ingress/emissary

Temporarily misconfigured routes after mapping change

Open

#4,629 opened on Oct 17, 2022

View on GitHub
 (2 comments) (1 reaction) (0 assignees)Python (679 forks)batch import
good first issuestalet:bug

Repository metrics

Stars
 (4,096 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I've noticed an issue where routes disappear for a very short period of time. We run very high frequency and notice some of our grpc clients are getting "Unimplemented" error code and a NR envoy code. I believe the issue is when a route is removed from route list in such a way that shifts all routes which seem to be named based on index in a list:

https://github.com/emissary-ingress/emissary/blob/1d62b9587a990dc6ecc754be2f27be2e2f577922/pkg/ambex/transforms.go#L140 - I suspect that while this reconfiguration is happening (usually < 1 sec) the routes sorted AFTER the route being removed are briefly unavailable.

Contributor guide

Research direction
Examine the route reordering logic in pkg/ambex/transforms.go, specifically the index based naming and ensure atomic updates to prevent temporary misconfiguration.
Tech stack
go
Domain
backendapi
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GoEnvoy proxygRPC
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40