ethereum/casper

Migrate sig hasher to vyper LLL

Open

#73 opened on Apr 5, 2018

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Python (184 forks)batch import
help wanted

Repository metrics

Stars
 (685 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Issue

Sig hasher is currently written in the deprecated Serpent. We should stop relying on Serpent compiler.

Proposed implementation

  • Migrate current sig hasher from serpent to vyper LLL
  • Port contract to this repo
  • Add sanity check testing to pytest build
  • Compile Purity Checker from source instead of using bytecode in the testing setup

Example Vyper LLL and compile techniques here https://github.com/ethereum/casper/blob/master/tests/utils/valcodes.py

Contributor guide

Research direction
Familiarize yourself with the current Serpent contract in sighash.se.py, understand Vyper LLL syntax by reviewing examples in tests/utils/valcodes.py, and plan how to port the contract while adding tests.
Tech stack
python
Domain
blockchainbackend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60