facebook/TestSlide

Suggest mock_(async)_callable from StrictMock

Open

#128 opened on Mar 16, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (58 forks)auto 404
Better Error MessagesStrictMockenhancementgood first issuehelp wanted

Repository metrics

Stars
 (147 stars)
PR merge metrics
 (PR metrics pending)

Description

StrictMock raises when an attribute is accessed, but has not been previously defined

https://github.com/facebookincubator/TestSlide/blob/8d516487247b6591c5a310c3e069ddb32d822d5f/testslide/strict_mock.py#L70

The message simply mentions "setting" the attribute. Let's improve this message to, if the mock has a template, and the attribute is callable, suggest using mock_callable / mock_async_callable to set it.

Contributor guide

Research direction
Examine the StrictMock class in testslide/strict mock.py, specifically the getattr method at line 70, and modify the error message to check if the attribute being accessed is callable and if a template exists, then suggest using mock callable or mock async callable.
Tech stack
python
Domain
testing qa
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70