facebook/TestSlide

Support for classes that define `__new__` for `mock_constructor`

Open

#155 opened on Apr 9, 2020

View on GitHub
 (1 comment) (0 reactions) (1 assignee)Python (58 forks)auto 404
enhancementhelp wantedmock_constructor

Repository metrics

Stars
 (147 stars)
PR merge metrics
 (PR metrics pending)

Description

It currently has no support for classes with __new__, and will reject patching those.

IIRC, it was tough getting around Python idiosyncrasies to make mock_constructor work, and I willingly decided not to implement __new__ at first to simplify things, but this is potentially doable.

Contributor guide

Research direction
Investigate Python's new method behavior and modify mock constructor to handle it by intercepting the object creation process.
Tech stack
python
Domain
testing
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Needs investigation
Prerequisites
Pythonmock
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50