facebook/TestSlide

Focus & Skip broken for unittest.TestCase decorated by @patch

Open

#2 opened on Oct 3, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (58 forks)auto 404
Python Unittestbughelp wanted

Repository metrics

Stars
 (147 stars)
PR merge metrics
 (PR metrics pending)

Description

For unittest.TestCase classes that are decorated with https://docs.python.org/3/library/unittest.mock.html#patch, when we do ftest or xtest, the decorator does to patch these methods, and we get a TypeError when running the test.

This happens because @patch is evaluated on the class loading, and it patches all methods there that begin with "test". Since ftest and xtest don't match the search, they're not decorated, and become broken.

Contributor guide

Research direction
Investigate how TestSlide's focus and skip decorators interact with unittest.mock.patch. The issue arises because @patch patches methods at class load time based on the pattern 'test*', but ftest and xtest methods are not patched, leading to TypeError.
Tech stack
python
Domain
testing
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Pythonunittest
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75