facebook/TestSlide

Add constructor input checks for matchers

Open

#233 opened on Sep 1, 2020

View on GitHub
 (0 comments) (0 reactions) (1 assignee)Python (58 forks)auto 404
Hacktoberfestenhancement

Repository metrics

Stars
 (147 stars)
PR merge metrics
 (PR metrics pending)

Description

When we do:

AnyInstanceOf(not_a_type)

we end up raising an exception not at the constructor, but rather when the comparison is being made, and isinstanceof (at AnyInstanceOf's code) will complain that not_a_type is... not a type.

Let's revisit all matchers & ensure that all of them raise ValueError if the constructor arguments are invalid from the constructor itself.

CC @deathowl

Contributor guide

Research direction
Inspect all matcher classes in the TestSlide codebase and add input validation in their init methods to raise ValueError for invalid arguments.
Tech stack
python
Domain
testing
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70