facebook/TestSlide

Validate if mock_callable() target has left over references

Open

#58 opened on Oct 25, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (58 forks)auto 404
enhancementhelp wantedmock(_async)_callable

Repository metrics

Stars
 (147 stars)
PR merge metrics
 (PR metrics pending)

Description

mock_constructor has validation logic to find out if the class being mocked has other references that are not from the module where it lives. This is important, as there's no guarantees it is gonna work otherwise.

mock_callable has the same potential problem when mocking functions at modules for example: if there are left over references such as from module import func, it will not work.

Let's add such validation to mock_callable so users don't shoot themselves in the foot.

This logic can be added here.

Contributor guide

Research direction
Study the existing validation logic in mock constructor.py (lines 275-295) to understand how it detects left over references. Then, in mock callable.py, locate the appropriate location (line 488) and implement a similar check for the target function or module, ensuring it catches cases like 'from module import func'.
Tech stack
python
Domain
testing qa
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40