facebook/fresco

Wide color gamut support for Postprocessors

Open

#2,103 opened on Apr 25, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Java (3,750 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (17,072 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

I want to load facebook logo image with fresco but when I am setting post processor, image not showing, looking to source code tells that fresco can not handle 16 bit png images, but this only happens when using post processor.

Reproduction

SimpleDraweeView image = findViewById(R.id.YOUR_SIMPLE_DRAWEE_VIEW);
String url = "https://www.facebook.com/images/fb_icon_325x325.png";

ImageRequest imageRequest = ImageRequestBuilder.newBuilderWithSource(Uri.parse(url))
        .setPostprocessor(new RoundAsCirclePostprocessor())
        .build();

PipelineDraweeController controller = (PipelineDraweeController) Fresco.newDraweeControllerBuilder()
        .setImageRequest(imageRequest)
        .setOldController(image.getController())
        .build();

image.setController(controller);

Additional Information

  • Fresco version: 1.9.0
  • Platform version: Android 8.0, One plus 5T

Contributor guide

Research direction
Investigate the postprocessor pipeline in Fresco to understand why wide color gamut images (16 bit PNG) fail. Look at how color space conversion is handled and if postprocessors bypass necessary conversions.
Tech stack
javaandroid
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaAndroid
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65