facebook/fresco

Improve bytearray handling

Open

#2,222 opened on Oct 9, 2018

View on GitHub
 (6 comments) (0 reactions) (0 assignees)Java (3,750 forks)batch import
good first issuehelp wanted

Repository metrics

Stars
 (17,072 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

NewByteArray can fail and return null, consider checking before using the returned value as array https://github.com/facebook/fresco/blob/2ae15501ad3fc132528f100990b9c06de4846e3a/imagepipeline/src/main/jni/imagepipeline/jpeg/jpeg_stream_wrappers.cpp#L135

Contributor guide

Research direction
Inspect the file imagepipeline/src/main/jni/imagepipeline/jpeg/jpeg stream wrappers.cpp at line 135. Add a null check for the result of NewByteArray before using it to avoid a potential crash.
Tech stack
cpp
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++JNIGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70