formulahendry/vscode-auto-close-tag

New setting proposal: onlyWithinQuotesOnLanguage

Open

#37 opened on Apr 24, 2017

View on GitHub
 (5 comments) (5 reactions) (0 assignees)TypeScript (52 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (180 stars)
PR merge metrics
 (PR metrics pending)

Description

Working in a language like typescript causes false tag closes when coding generics. A new setting that restricts closes to only when typing in a quoted string would allow users to keep this feature enabled with far less false closes. Coding angular inline templates is an example of where this might be used.

"auto-close-tag.onlyWithinQuotesOnLanguage": [
    "typescript"
]

Edit: I'm not sure what information the extension environment provides. Maybe there is a better way, such as knowing you're in a generic - or something similar.

Contributor guide

Research direction
Examine the extension's source code to understand how it determines context (e.g., isInsideQuotes) and explore how to add language specific configuration for the onlyWithinQuotes behavior.
Tech stack
typescript
Domain
developer experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
VSCode Extension API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60