formulahendry/vscode-auto-close-tag

Undo should not trigger auto tag closing

Open

#78 opened on Mar 15, 2018

View on GitHub
 (0 comments) (2 reactions) (0 assignees)TypeScript (52 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (180 stars)
PR merge metrics
 (PR metrics pending)

Description

Steps to reproduce:

  1. Copy paste <div> into editor, and delete >.
  2. Undo, and it auto closes the div tag.

This seem to be a quite dangerous behavior to me, because sometimes I would rely on redo to do some dangerous temporary rolling back for testing purpose. And this behavior could clean the redos.

Contributor guide

Research direction
Investigate the undo event handling in the extension. Ensure that auto tag closing is not triggered by undo operations. Check if the extension listens to DocumentChange events and verify that it ignores changes that are part of an undo/redo transaction.
Tech stack
typescript
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptVSCode extension API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65