fury-gl/fury

Cylinder actor needs to use repeat_primitives by default

Open

#531 opened on Jan 21, 2022

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Python (253 forks)auto 404
good first issuetype:Enhancement

Repository metrics

Stars
 (301 stars)
PR merge metrics
 (PR metrics pending)

Description

This will allow the cylinder to have the same behavior when picking vertices or edges as with other primitives.

However, we should also keep repeat_sources as a secondary option just in case we need to use some of the other VTK filters.

See an example of box actor (using repeat_primitives) here https://github.com/fury-gl/fury/blob/master/fury/actor.py#L1696

See the current implementation of cylinder here https://github.com/fury-gl/fury/blob/master/fury/actor.py#L1564

Contributor guide

Research direction
Implement the cylinder actor to use repeat primitives by default, similar to the box actor, while keeping repeat sources as a secondary option. Refer to the box actor implementation at https://github.com/fury gl/fury/blob/master/fury/actor.py#L1696 and modify the cylinder implementation at https://github.com/fury gl/fury/blob/master/fury/actor.py#L1564.
Tech stack
python
Domain
computer graphics
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65