getzola/zola

Some valid yaml dates are treated as invalid

Open

#2,071 opened on Jan 15, 2023

View on GitHub
 (15 comments) (0 reactions) (0 assignees)Rust (1,046 forks)batch import
bughelp wanted

Repository metrics

Stars
 (15,349 stars)
PR merge metrics
 (Avg merge 48d 17h) (4 merged PRs in 30d)

Description

Bug Report

Environment

Zola version: zola 0.16.1

Expected Behavior

This front-matter should parse successfully (see https://www.yamllint.com/ for an example of another tool that can parse it; this was originally migrated from a Jekyll site which can also parse it):

---
layout:	post
title:	"Hosting an SSH Server"
date:	"2017-12-27 20:46:24 -0500"
excerpt: I decided one day that I really wanted a remote server.
audience: tech-savvy
---

Current Behavior

PS C:\Users\jyn\src\third-website> zola serve                     
Building site...
Error: Failed to serve the site
Error: Error when parsing front matter of section `\\?\C:\Users\jyn\src\third-website\content\blog\2017-12-27-Hosting-an-SSH-Server.md`
Error: Reason: YAML deserialize error: Error("failed to parse datetime", line: 2, column: 1)

I think the problem is that dates are unconditionally parsed as toml dates, which is not correct: https://github.com/getzola/zola/blob/39bfbcd0199340ce5de4d0b951a2050cc9fc239e/components/content/src/front_matter/page.rs#L31-L33

Step to reproduce

Add the given frontmatter to any .md file in content/blogs.

Contributor guide

Research direction
Inspect the front matter parsing code in components/content/src/front matter/page.rs to understand how dates are parsed and modify it to handle quoted YAML dates correctly.
Tech stack
rust
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitRust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75