getzola/zola

Broken shortcodes on 0.19

Open

#2,565 opened on Jul 3, 2024

View on GitHub
 (19 comments) (1 reaction) (0 assignees)Rust (1,046 forks)batch import
buggood first issuehelp wanted

Repository metrics

Stars
 (15,349 stars)
PR merge metrics
 (Avg merge 48d 17h) (4 merged PRs in 30d)

Description

I had a shortcode called email which contained my email address for reasons, and used it as such

<a name="contact-me" href="mailto:{{ email() }}">{{ email() }}</a>

This used to work but I have since upgraded to 0.19.1 and it simply outputs @@ZOLA_SC_PLACEHOLDER@@

I had to move the entire tag into the shortcode for it to work again, but this smells like a bug and a regression to me.

Contributor guide

Research direction
Find the place in the code where shortcode placeholders are replaced with their actual output. Focus on the handling of inline shortcodes (e.g., `{{ email() }}`) within HTML attributes or tags. Check if the replacement occurs before or after attribute parsing, and whether the placeholder is being incorrectly left in the output.
Tech stack
rust
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitRust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65