ggml-org/ggml

ggml : add FFT operator

Open

#1,049 opened on Dec 14, 2024

View on GitHub
 (2 comments) (3 reactions) (0 assignees)C++ (1,646 forks)auto 404
enhancementgood first issue

Repository metrics

Stars
 (14,741 stars)
PR merge metrics
 (Avg merge 33m) (12 merged PRs in 30d)

Description

It would be nice to have a simple implementation of FFT. The main goal is to be able to keep the data inside a ggml graph in certain scenarios (such as in Whisper and various TTS models), even if the performance is not as good as dedicated libraries (such as FFTW and cuFFT). I think we can start with a basic Cooley-Tukey implementation to keep things simple. Batched 1D FFT should be supported, as well as common variations such as inverse FFT and real-valued FFT.

Contributor guide

Research direction
Study existing ggml operator implementations (e.g., ggml mul mat) for patterns; implement Cooley Tukey FFT for 1D with batching, inverse, real valued variants; ensure integration with ggml graph.
Tech stack
cpp
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50