ggml-org/whisper.cpp

errorlevel not set when exiting with errors in windows version

Open

#555 opened on Mar 2, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (5,535 forks)batch import
enhancementgood first issue

Repository metrics

Stars
 (49,693 stars)
PR merge metrics
 (Avg merge 5d 20h) (36 merged PRs in 30d)

Description

It seems to me that main.exe sets no errorlevel when it exits with error. IMHO it should not exit with errorlevel = 0

Contributor guide

Research direction
Check main.exe's exit code handling on Windows by inspecting the source code in main.cpp for error return values and ensure proper errorlevel is set.
Tech stack
ccpp
Domain
cli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C/C++Windows command line
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90