go-chi/chi

Refactor throttle middleware tests as prone to intermittent failure

Open

#608 opened on Mar 25, 2021

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Go (555 forks)batch import
help wanted

Repository metrics

Stars
 (8,127 stars)
PR merge metrics
 (Avg merge 16h 36m) (2 merged PRs in 30d)

Description

https://github.com/go-chi/chi/blob/master/middleware/throttle_test.go

It's often that when I submit a PR, and the code runs through github ci, it will fail -- https://github.com/go-chi/chi/actions

I have to re-run the jobs to have it pass, it seems to be a timing issue. When running locally, it seems to work well pretty consistently, but I've seen the rare failing case.

Contributor guide

Research direction
Study the throttle middleware test to identify timing dependencies and refactor to use deterministic patterns like channel synchronization or mock time.
Tech stack
go
Domain
backend
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75