go-kit/kit

Fix sd/etcd and sd/etcdv3 integration test flakes

Open

#882 opened on Jun 6, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Go (2,446 forks)batch import
bughelp wanted

Repository metrics

Stars
 (27,422 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

The sd/etcd and sd/etcdv3 integration tests are extremely flaky. I can generally expect them to trigger build failures on every PR. Here is one example.

I am going to disable those tests until they can be fixed. This issue is a plea for help from the community to fix them.

Contributor guide

Research direction
Investigate the failing etcd integration tests, reproduce the flakes, and fix the underlying race conditions or timing issues.
Tech stack
go
Domain
backend
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Goetcd
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75