golang/go

cmd/dist: run all tests unless explicitly disabled on a platform

Open

#18,503 opened on Jan 3, 2017

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Go (19,008 forks)batch import
NeedsFixhelp wanted

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Every now and again a test isn't enabled on a platform where it should be (for example: https://github.com/golang/go/commit/161cd34f788ee9c6b61565eb6f865434bc135306). A leading culprit of this is feature checks that only run a test if the GOOS/GOARCH combination is in a list:

pair := t.gohostos + "-" + t.goarch
switch (pair) {
case "android-arm", "darwin-arm", ...:
    // run test
default:
    // don't run test
}

If a GOOS/GOARCH combination isn't correctly added to one of the many lists like this, then the related tests simply won't run. This is not always obvious.

I think it would be good to refactor test.go so that it always defaults to running a test unless explicitly told not to for a given platform (preferably with an issue referencing the missing feature). This will make it harder to accidentally forget to enable a test.

Contributor guide

Research direction
Examine test.go in cmd/dist to find all places where tests are conditionally skipped based on GOOS/GOARCH lists, then refactor to default run with explicit exclusion lists referencing issues for missing features.
Tech stack
go
Domain
testing
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60