golang/go

x/build: number of test failures

Open

#22,254 opened on Oct 13, 2017

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Go (19,008 forks)batch import
Buildershelp wanted

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

In lieu of an automated builder, I run the x/build tests in Travis CI. @andybons has fixed two problems with cmd/cl and with cloud.google.com depedencies, but this has revealed a number of underlying test failures:

--- FAIL: TestConnAgainstNetTest (2.03s)
	revdial_test.go:236: warning: the revdial's SetWriteDeadline support is not complete; some tests involving write deadlines known to be flaky
    --- PASS: TestConnAgainstNetTest/BasicIO (0.41s)
    --- PASS: TestConnAgainstNetTest/PingPong (0.19s)
    --- PASS: TestConnAgainstNetTest/RacyRead (0.34s)
    --- FAIL: TestConnAgainstNetTest/RacyWrite (0.42s)
    	testing.go:610: race detected during execution of test

TestCorpusCheck causes the entire Go corpus to download to the test instance, which eventually runs out of memory.

2017/10/13 18:26:13 Downloading 9495471 bytes of https://maintner.golang.org/logs/27 ...
2017/10/13 18:26:13 wrote /home/travis/.cache/golang-maintner/0027.growing.mutlog
fatal error: runtime: out of memory

Also, we need to update the go-github version for the gitmirror Docker file, I believe; IsPullRequest was added very recently.

src/golang.org/x/build/maintner/github.go:802: d.b.IsPullRequest undefined (type *github.Issue has no field or method IsPullRequest)
Removing intermediate container 65ca938e2dcb
The command '/bin/sh -c go install golang.org/x/build/cmd/gitmirror' returned a non-zero code: 2
make: *** [build0] Error 2

Contributor guide

Research direction
Investigate the three test failures: the RacyWrite race condition in revdial, the TestCorpusCheck memory issue, and the gitmirror dependency error. Reproduce locally with `go test`. For RacyWrite, look for data races in revdial test.go. For TestCorpusCheck, consider mocking the corpus download. For gitmirror, update the go github version.
Tech stack
go
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60