golang/go

x/review/git-codereview: do not mail CLs with editor temp files, binaries

Open

#24,139 opened on Feb 26, 2018

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Go (19,008 forks)batch import
NeedsFixhelp wanted

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Motivated by #23800, git-codereview should probably refuse to mail CLs with editor temp files and binaries.

Contributor guide

Research direction
Investigate the git codereview tool's mail submission logic. Determine how to detect editor temporary files (e.g., .swp, .bak, ~) and binary files (e.g., .exe, .bin) in the list of changed files. Implement validation to refuse mailing if such files are present. Look at existing Go libraries for file type detection or use filepath extension checks.
Tech stack
go
Domain
developer experiencetooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65