golang/go

crypto/x509: ensure CreateCertificate won't generate unparsable certificates

Open

#24,156 opened on Feb 27, 2018

View on GitHub
 (5 comments) (2 reactions) (0 assignees)Go (19,008 forks)batch import
NeedsFixTestinghelp wanted

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

CreateCertificate should return an error instead of generating a certificate that will fail ParseCertificate. We should check that's the case and maybe test or enforce this.

See #23995.

Contributor guide

Research direction
Examine the test file for ParseCertificate in crypto/x509. Add a validation step in CreateCertificate to ensure the generated certificate can be parsed by ParseCertificate, or add a test that verifies this behavior.
Tech stack
go
Domain
backendsecurity
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Gocrypto
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60