golang/go

x/build/cmd/gerritbot: Gobot shouldn't be added as a CC/Reviewer

Open

#24,382 opened on Mar 13, 2018

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Go (19,008 forks)batch import
BuildersNeedsFixhelp wanted

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Gobot is added as a CC when it says "Trybots beginning", and as a Reviewer when it posts Trybot-Result+1 or Trybot-Result-1. For example, see: https://go-review.googlesource.com/c/go/+/100475

I realise that this is how Gerrit is supposed to work for humans - a user should be subscribed to updates if they comment, and added as a reviewer if they touch one of the flags/labels. However, I think this is noisy for bots. Is there a way to keep it from happening?

Contributor guide

Research direction
Examine the gerritbot code to identify where comments and label changes trigger CC/reviewer additions, then implement logic to skip these actions for the bot's own account (e.g., check if the comment author is the bot).
Tech stack
go
Domain
backendci cddevops
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoGerritGerritBot
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65