golang/go

path/filepath: TestEvalSymlinks tests with "/" prefix fail in Windows

Open

#24,846 opened on Apr 13, 2018

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Go (19,008 forks)batch import
NeedsInvestigationOS-Windowshelp wanted

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

What version of Go are you using (go version)?

go version go1.10.1 windows/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

set GOARCH=amd64 set GOHOSTARCH=amd64 set GOHOSTOS=windows set GOOS=windows

What did you do?

Built go using "all.bat"

What did you expect to see?

while running tests ok path/filepath x.xxxs

What did you see instead?

--- FAIL: TestEvalSymlinks (0.04s) path_test.go:798: EvalSymlinks("C:\Users\varga\AppData\Local\Temp\evalsymlink400713581\test/linkabs") returns "C:\", want "/" FAIL FAIL path/filepath 1.552s

I have a code fix for this if this. Essentially just prepending the expected result with the volume name if we are on Windows and the path has a prefix of "/".

Does that sound reasonable?

Contributor guide

Research direction
Inspect the failing test and understand how EvalSymlinks handles Windows paths with a forward slash prefix. The fix likely involves prepending the volume name (e.g., "C:") to the expected result when the path starts with "/" on Windows.
Tech stack
go
Domain
backendtesting
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoWindows
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70